-
Notifications
You must be signed in to change notification settings - Fork 165
MinIO updates in ECE docs #1996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔍 Preview links for changed docs |
deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🎸
Very nice!
…sitory.md Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.md
Outdated
Show resolved
Hide resolved
|
@kilfoyle , would you mind re-reviewing this again? I've made significant changes after a conversation with Omer, Alex P and support folks. The previous version was making the impression that it was ok to run MinIO directly within ECE hosts, and we have decided to recommend against it, as MinIO should run on its own infrastructure for multiple reasons. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.md
Outdated
Show resolved
Hide resolved
deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.md
Outdated
Show resolved
Hide resolved
|
LGTM! 🚀 |
Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
In relation with https://github.com/elastic/cloud/issues/134936, we have realized that the doc
/deploy-manage/tools/snapshot-and-restore/minio-on-premise-repository.mdwas really outdated and needed some love.This is the main page to review:
MinIO self-managed repository
Applied changes:
MinIOacross all docs. No minio or Minio anymore.offlinetoair-gapped(for consistency with the new IA and new docs).on-premisetoself-managed(because ECE hosts or the customer minio hosts could be on-premises or on cloud VMs technically. What they are in reality isself-managed).Closes https://github.com/elastic/cloud/issues/134936